[PWGLF] Add a workflow for (anti)triton analysis#17151
Open
AnalitikGnid wants to merge 8 commits into
Open
Conversation
AnalitikGnid
requested review from
HorstMa,
alibuild,
fmazzasc,
maciacco,
mpuccio,
omvazque and
skundu692
as code owners
July 21, 2026 12:47
github-actions
Bot
changed the title
|
O2 linter results: ❌ 1 errors, |
Collaborator
|
Error while checking build/O2Physics/staging for 3da74bd at 2026-07-21 14:55: Full log here. |
Collaborator
|
Error while checking build/O2Physics/code-check for bc69f0c at 2026-07-21 16:49: Full log here. |
vkucera
requested changes
Jul 21, 2026
vkucera
left a comment
vkucera
left a comment
Collaborator
There was a problem hiding this comment.
Since you are adding a new file, make sure it's clean from errors and warnings.
Collaborator
vkucera
reviewed
Jul 24, 2026
| std::pair<int, std::vector<float>> TPCcuts; | ||
| std::pair<int, std::vector<float>> TOFcuts; | ||
|
|
||
| static constexpr float kMassTriton = o2::constants::physics::MassTriton; // GeV/c^2 |
Collaborator
There was a problem hiding this comment.
- Follow the O2 naming conventions. This is not ROOT. Don't use the
kprefix. - You just created an unnecessary alias for an existing constant. Use the constant directly.
Comment on lines
+102
to
+104
| std::pair<int, std::vector<float>> ITScuts; | ||
| std::pair<int, std::vector<float>> TPCcuts; | ||
| std::pair<int, std::vector<float>> TOFcuts; |
Collaborator
There was a problem hiding this comment.
Follow naming conventions.
Comment on lines
+115
to
+123
| std::shared_ptr<TH1> eta; | ||
| std::shared_ptr<TH2> eta_to_y; | ||
| std::shared_ptr<TH1> y; | ||
| std::shared_ptr<TH1> phi; | ||
| std::shared_ptr<TH1> p; | ||
| std::shared_ptr<TH1> pt; | ||
| std::shared_ptr<TH2> dcaxy_to_p; | ||
| std::shared_ptr<TH2> dcaxy_to_pt; | ||
| std::shared_ptr<TH2> dcaz_to_p; |
Collaborator
There was a problem hiding this comment.
Follow naming conventions.
| } | ||
|
|
||
| template <typename TrackType> | ||
| static float getMTOF(const TrackType& track) |
Collaborator
There was a problem hiding this comment.
Follow naming conventions.
| void fillHistSet(HistSet& h, const TrackType& track, int pdg) | ||
| { | ||
| const float mass = kMassTriton; | ||
| const auto y = static_cast<float>(RecoDecay::y(std::array{track.px(), track.py(), track.pz()}, mass)); |
Collaborator
There was a problem hiding this comment.
Suggested change
| const auto y = static_cast<float>(RecoDecay::y(std::array{track.px(), track.py(), track.pz()}, mass)); | |
| const auto y = static_cast<float>(RecoDecay::y(track.pVector(), mass)); |
Contributor
Author
There was a problem hiding this comment.
This track type doesn't have a pVector() accessor.
Collaborator
Collaborator
|
Error while checking build/O2Physics/code-check for 890b1bd at 2026-07-25 12:16: Full log here. |
Collaborator
|
Error while checking build/O2Physics/code-check for 53d0a1a at 2026-07-27 05:02: Full log here. |
Collaborator
|
Error while checking build/O2Physics/code-check for 963093b at 2026-07-27 07:25: Full log here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new workflow for measuring (anti)triton production in Run 3 data
Dependencies
Uses output of the o2-analysis-cf-single-track-selector (https://aliceo2group.github.io/analysis-framework/docs/datamodel/pwgTables.html)
Links
Presented at the Nuclei and Exotica PAG meeting on Thursday, 16th July, 2026 (https://indico.cern.ch/event/1688019/)